Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] calendar_attachment: Show attachments in modal window #105

Closed
wants to merge 1 commit into from
Closed

[ADD] calendar_attachment: Show attachments in modal window #105

wants to merge 1 commit into from

Conversation

tarteo
Copy link
Member

@tarteo tarteo commented Sep 27, 2023

The calendar view opens the form in a modal window therefore the chatter is not visible.
This module adds a tab with the attachments on the event form, so the attachments are
also accessible from the calendar view.

image

@pedrobaeza
Copy link
Member

Isn't better as a general approach to include a way to open the event full form from the popup or the dropdown?

@tarteo
Copy link
Member Author

tarteo commented Sep 27, 2023

Hey @pedrobaeza, If it opens a new window or uses the current window depends on how it's implemented e.g. sale.order calendar opens the record in the current window.
Even then, the customer wants to use the modal window for the calendar app (calendar.event).

@pedrobaeza
Copy link
Member

OK, it was just a suggestion specific to calendar.event. You can go this way.

@tarteo
[ADD] calendar_attachment: Show attachments in modal window
308abc4 
[ADD] calendar_attachment: Show attachments in modal window
@tarteo tarteo force-pushed the 16-add-calendar-attachment branch from b680e3a to 308abc4 Compare September 27, 2023 14:02
@ICTRV
Copy link

ICTRV commented Sep 28, 2023

this looks good so far

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 12, 2024
@github-actions github-actions bot closed this Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarteo @pedrobaeza @ICTRV